Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test of IsGood() #487

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

Mdaiki0730
Copy link
Member

Description

Add test to this implementation
#484

@Mdaiki0730 Mdaiki0730 self-assigned this Nov 8, 2022
@Mdaiki0730 Mdaiki0730 added the C: test Classification: Add test case label Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #487 (a95169f) into main (955cfde) will decrease coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
- Coverage   65.56%   65.45%   -0.11%     
==========================================
  Files         278      278              
  Lines       37927    37927              
==========================================
- Hits        24867    24826      -41     
- Misses      11251    11292      +41     
  Partials     1809     1809              
Impacted Files Coverage Δ
crypto/sr25519/pubkey.go 35.89% <0.00%> (-7.70%) ⬇️
blockchain/v0/pool.go 78.81% <0.00%> (-5.69%) ⬇️
p2p/pex/pex_reactor.go 79.67% <0.00%> (-1.85%) ⬇️
consensus/reactor.go 74.84% <0.00%> (-1.51%) ⬇️
consensus/msgs.go 84.19% <0.00%> (-0.92%) ⬇️
blockchain/v0/reactor.go 69.49% <0.00%> (-0.68%) ⬇️
proxy/multi_app_conn.go 47.66% <0.00%> (ø)
consensus/state.go 73.44% <0.00%> (+0.11%) ⬆️
light/client.go 62.05% <0.00%> (+0.44%) ⬆️
p2p/pex/addrbook.go 71.66% <0.00%> (+0.50%) ⬆️
... and 3 more

@Mdaiki0730 Mdaiki0730 merged commit 65eeb6e into Finschia:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: test Classification: Add test case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants